Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level of an error during Prune #2141

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Oct 5, 2023

Why this should be merged

It isn't easy to allow cancelling Prune, because Shutdown is called with the context lock held and Prune may be blocked on acquiring the context lock. So, it is expected that Prune may return an error during VM shutdown. This is still normally unexpected, so keeping the level at WARN.

How this works

ERROR -> WARN

How this was tested

CI

@StephenButtolph StephenButtolph added the monitoring This primarily focuses on logs, metrics, and/or tracing label Oct 5, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Oct 5, 2023
@StephenButtolph StephenButtolph self-assigned this Oct 5, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 5, 2023
Merged via the queue into dev with commit 5189c39 Oct 5, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the reduce-prune-error-log-level branch October 5, 2023 05:27
@StephenButtolph StephenButtolph added the antithesis Related to an issue reported by Antithesis label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antithesis Related to an issue reported by Antithesis monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants